Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 )
Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests ...................................................................... Patch Set 6: Hi all, please let me know if there is any comment on this patch. This patch does not contain any functionality change. It was prepared according to Qifan's suggestions in the following. 1. https://gerrit.cloudera.org/c/19194/15//COMMIT_MSG#7. I added a new test case at https://gerrit.cloudera.org/c/19394/6/tests/authorization/test_ranger.py#1254 to include the scenario where UDF is called in an INSERT statement. 2. https://gerrit.cloudera.org/c/19194/15/tests/authorization/test_ranger.py#482. The code comment has been revised at https://gerrit.cloudera.org/c/19394/6/tests/authorization/test_ranger.py#528. 3. https://gerrit.cloudera.org/c/19194/15/tests/authorization/test_ranger.py#526. I refactored the code by wrapping the pattern in the function _update_privileges_and_verify() at https://gerrit.cloudera.org/c/19394/6/tests/authorization/test_ranger.py#192. This pattern is used throughout test_ranger.py. I only refactored the code added in IMPALA-10986 and not very sure whether I should also refactor the functions not touched in IMPALA-10986. -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 6 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 03 Jan 2023 17:23:55 +0000 Gerrit-HasComments: No
