Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 )
Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/19394/7/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/19394/7/tests/authorization/test_ranger.py@329 PS7, Line 329: "grant create on user_defined_fn {0}.{1} " The idention looks lengthy. Can we use the second idention style mentioned here? https://peps.python.org/pep-0008/#indentation self._update_privileges_and_verify( admin_client, "grant create on user_defined_fn {0}.{1} to {2} {3}"... -- To view, visit http://gerrit.cloudera.org:8080/19394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4f69934401a745da66a983528a7a3679279c28 Gerrit-Change-Number: 19394 Gerrit-PatchSet: 7 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 05 Jan 2023 04:36:05 +0000 Gerrit-HasComments: Yes
