Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/19378 )
Change subject: IMPALA:11808: Added support for reload event in catalogD ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/19378/4/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/19378/4/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@518 PS4, Line 518: FireEventRequestData data = new FireEventRequestData(); > What is the expectation for other HMS users than Impala when receiving this Yeah, they'll have to ignore this event. http://gerrit.cloudera.org:8080/#/c/19378/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/19378/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6401 PS4, Line 6401: MetastoreShim.fireReloadEventHelper(catalog_.getMetaStoreClient(), > Do I understand correctly that we do not check whether the table has actual Yeah, we'll always send a refresh event because there is no way of knowing if, in fact, something has really changed for a refresh to take place. In this case, we can introduce a config to disable this feature by default. And only enable if this feature is really required in a multi-catalogD environment. Regarding multiple refreshes, I'll create a follow-up Jira to track the optimization patch for this feature. -- To view, visit http://gerrit.cloudera.org:8080/19378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic62d58837d356dc2113f3c0904228ac9de484136 Gerrit-Change-Number: 19378 Gerrit-PatchSet: 4 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 03 Jan 2023 20:32:22 +0000 Gerrit-HasComments: Yes
