Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/19378 )
Change subject: IMPALA:11808: Added support for reload event in catalogD ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/19378/5/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/19378/5/be/src/catalog/catalog-server.cc@127 PS5, Line 127: enable_reload_events, false, " > The name sounds like only applying on the processing side and not the trigg Ack http://gerrit.cloudera.org:8080/#/c/19378/5/fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/19378/5/fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java@446 PS5, Line 446: throws MetastoreNotificationException{ : throw new MetastoreNotificationException("Reload event is not supported.");; : } > We can't use these if they don't exist in Apache Hive3. We can make this me Done http://gerrit.cloudera.org:8080/#/c/19378/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/19378/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6410 PS5, Line 6410: LOG.warn(String.format("Couldn't obtain a version lock for the table: %s. " + > nit: also mention that reload events won't be fired. Added more log saying that self-event will not be detected. http://gerrit.cloudera.org:8080/#/c/19378/5/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/19378/5/tests/custom_cluster/test_events_custom_configs.py@254 PS5, Line 254: last_event = events[0] > Can we also verify the fired reload event? We have an example here: Done -- To view, visit http://gerrit.cloudera.org:8080/19378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic62d58837d356dc2113f3c0904228ac9de484136 Gerrit-Change-Number: 19378 Gerrit-PatchSet: 6 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 04 Jan 2023 20:13:13 +0000 Gerrit-HasComments: Yes
