Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19378 )
Change subject: IMPALA-11808: Add support for reload event in catalogD ...................................................................... Patch Set 10: Code-Review+1 (2 comments) LGTM. Thanks for adding this feature! http://gerrit.cloudera.org:8080/#/c/19378/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/19378/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6417 PS8, Line 6417: MetastoreShim.fireReloadEventHelper(catalog_.getMetaStoreClient(), > Self-events are detected using the catalog service id and catalog version. Ack http://gerrit.cloudera.org:8080/#/c/19378/8/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/19378/8/tests/custom_cluster/test_events_custom_configs.py@246 PS8, Line 246: > There is no partition info in the notification event. we'll have to deseria Ack -- To view, visit http://gerrit.cloudera.org:8080/19378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic62d58837d356dc2113f3c0904228ac9de484136 Gerrit-Change-Number: 19378 Gerrit-PatchSet: 10 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 05 Jan 2023 03:50:32 +0000 Gerrit-HasComments: Yes
