Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19378 )
Change subject: IMPALA-11808: Add support for reload event in catalogD ...................................................................... Patch Set 10: Code-Review+1 (5 comments) The code looks good to me, some comments for the commit message http://gerrit.cloudera.org:8080/#/c/19378/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19378/10//COMMIT_MSG@7 PS10, Line 7: reload even Is there a jira about adding this new event in HMS? It could be mentioned in the commit message http://gerrit.cloudera.org:8080/#/c/19378/10//COMMIT_MSG@9 PS10, Line 9: This patch supports a new event called reload event in catalogD. Can you add a few more info? - both sending and processing of the event is implemented in this patch - the flag could be mentioned and that it is disabled by default http://gerrit.cloudera.org:8080/#/c/19378/10//COMMIT_MSG@12 PS10, Line 12: invlidate typo http://gerrit.cloudera.org:8080/#/c/19378/10//COMMIT_MSG@13 PS10, Line 13: A bit of info could be added about testing - currently only event creating and self event checking is implemented. It would be great to have tests for the event processing too - a TODO could be added about this. http://gerrit.cloudera.org:8080/#/c/19378/10/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/19378/10/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@549 PS10, Line 549: throws MetastoreNotificationException{ nit: extra space -- To view, visit http://gerrit.cloudera.org:8080/19378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic62d58837d356dc2113f3c0904228ac9de484136 Gerrit-Change-Number: 19378 Gerrit-PatchSet: 10 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 05 Jan 2023 10:11:07 +0000 Gerrit-HasComments: Yes
