Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19423 )

Change subject: IMPALA-11658: Implement Iceberg manifest caching config for 
Impala
......................................................................


Patch Set 1: Code-Review+1

(3 comments)

Thanks for working on this, LGTM!

http://gerrit.cloudera.org:8080/#/c/19423/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19423/1//COMMIT_MSG@9
PS1, Line 9: need
nit: needs


http://gerrit.cloudera.org:8080/#/c/19423/1//COMMIT_MSG@10
PS1, Line 10: implement
nit: implements


http://gerrit.cloudera.org:8080/#/c/19423/1//COMMIT_MSG@19
PS1, Line 19: - Checked that manifest caching works through debug logging.
Does it works in case of HadoopTables and Catalogs as well?



--
To view, visit http://gerrit.cloudera.org:8080/19423
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a60a700d2ae6302dfe395d1ef602e6b1d821888
Gerrit-Change-Number: 19423
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Wed, 18 Jan 2023 14:52:17 +0000
Gerrit-HasComments: Yes

Reply via email to