Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19110 )

Change subject: WIP IMPALA-11629: Support for huawei OBS FileSystem
......................................................................


Patch Set 7:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/19110/7/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/19110/7/bin/impala-config.sh@696
PS7, Line 696:   export OBS_ACCESS_KEY="${OBS_ACCESS_KEY:?OBS_ACCESS_KEY cannot 
be an empty string for OBS}"
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/19110/7/bin/impala-config.sh@697
PS7, Line 697:   export OBS_SECRET_KEY="${OBS_SECRET_KEY:?OBS_SECRET_KEY cannot 
be an empty string for OBS}"
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/19110/7/testdata/bin/create-load-data.sh
File testdata/bin/create-load-data.sh:

http://gerrit.cloudera.org:8080/#/c/19110/7/testdata/bin/create-load-data.sh@122
PS7, Line 122: SCHEMA_MISMATCH_ERROR+="but it cannot be loaded on Isilon, s3, 
gcs, cos, oss, obs or local "
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/19110/7/tests/common/skip.py
File tests/common/skip.py:

http://gerrit.cloudera.org:8080/#/c/19110/7/tests/common/skip.py@83
PS7, Line 83: S
flake8: E501 line too long (92 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/19110/7/tests/util/filesystem_utils.py
File tests/util/filesystem_utils.py:

http://gerrit.cloudera.org:8080/#/c/19110/7/tests/util/filesystem_utils.py@65
PS7, Line 65: '
flake8: E501 line too long (103 > 90 characters)



--
To view, visit http://gerrit.cloudera.org:8080/19110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84a54dbebcc5b71e9bcdd141dae9e95104d98cb1
Gerrit-Change-Number: 19110
Gerrit-PatchSet: 7
Gerrit-Owner: Xiang Yang <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Xiang Yang <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Mon, 23 Jan 2023 06:02:19 +0000
Gerrit-HasComments: Yes

Reply via email to