Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19110 )
Change subject: WIP IMPALA-11629: Support for huawei OBS FileSystem ...................................................................... Patch Set 8: (2 comments) Hi yida, I do the ee test as described in commit message, following quanlong's blog: https://blog.csdn.net/huang_quanlong/article/details/114937678. This is the result: https://issues.apache.org/jira/secure/attachment/13054770/obs_ee_test_core_results.csv and the hdfs ee test log: https://issues.apache.org/jira/secure/attachment/13054772/hdfs_ee_test.log and the obs ee test log: https://issues.apache.org/jira/secure/attachment/13054771/obs_ee_test.log I found there are some failed cases, such as 'tests/data_errors/test_data_errors.py::TestAvroErrors::test_avro_errors', failed because of the '$NAMENODE' variable. May be we can replace it to '$DEFAULT_FS'. Another failed case is './bin/impala-py.test tests/query_test/test_iceberg.py::TestIcebergTable::test_load', maybe because of the random generated database's location is defaulted to HDFS. Do you think I should solve these problems in this patch, or create a new jira issue? CC quanlong, thanks for review this. http://gerrit.cloudera.org:8080/#/c/19110/8/tests/custom_cluster/test_metastore_service.py File tests/custom_cluster/test_metastore_service.py: http://gerrit.cloudera.org:8080/#/c/19110/8/tests/custom_cluster/test_metastore_service.py@1176 PS8, Line 1176: if IS_HDFS: Hi yida, quanlong, do you accept this simplify method? http://gerrit.cloudera.org:8080/#/c/19110/8/tests/custom_cluster/test_metastore_service.py@1204 PS8, Line 1204: if IS_HDFS: Hi yida, quanlong, same as above -- To view, visit http://gerrit.cloudera.org:8080/19110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84a54dbebcc5b71e9bcdd141dae9e95104d98cb1 Gerrit-Change-Number: 19110 Gerrit-PatchSet: 8 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 23 Jan 2023 06:42:44 +0000 Gerrit-HasComments: Yes
