Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19324 )
Change subject: IMPALA-11476: Support Ozone erasure coding ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/19324/11/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/19324/11/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@233 PS11, Line 233: if (fs instanceof DistributedFileSystem) { > Is it possible for us to use isDistributedFilesystem() and isOzoneFileSyste It is, although we'll need a specialization for isOfsFileSystem or still have to test instanceof. Is it about performance or semantics? http://gerrit.cloudera.org:8080/#/c/19324/11/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@316 PS11, Line 316: switch (tokens.countTokens()) { : case 0: : return Pair.create("", ""); : case 1: : return Pair.create(tokens.nextToken(), ""); : default: : return Pair.create(tokens.nextToken(), tokens.nextToken()); : } > Nit: Can we have local variables corresponding to volume and bucket and the Sure. I don't really need to rewrite this, just noticed a StringTokenizer would cover the logic I already had when I was looking at more parsing for volume/bucket/key. -- To view, visit http://gerrit.cloudera.org:8080/19324 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I201e2e33ce94bbc1e81631a0a315884bcc8047d1 Gerrit-Change-Number: 19324 Gerrit-PatchSet: 11 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 24 Jan 2023 20:17:05 +0000 Gerrit-HasComments: Yes
