Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19324 )
Change subject: IMPALA-11476: Support Ozone erasure coding ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/19324/11/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/19324/11/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@233 PS11, Line 233: DistributedFileSystem dfs = (Distributed > We switched to using the scheme in IMPALA-10266. https://github.com/apache/ Done http://gerrit.cloudera.org:8080/#/c/19324/11/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@316 PS11, Line 316: } : return numFilesMoved; : } : : // Returns the first two elements (volume, bucket) of the unqualified path. : public static Pair<String, String> volumeBucketPair(Path p) { : String path = Path.getPathWithoutSchemeAndAuthority(p).toString(); : S > Refactoring is fine. My nit is that I find multiple arguments of tokens.nex Done -- To view, visit http://gerrit.cloudera.org:8080/19324 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I201e2e33ce94bbc1e81631a0a315884bcc8047d1 Gerrit-Change-Number: 19324 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 24 Jan 2023 21:00:27 +0000 Gerrit-HasComments: Yes
