Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19442 )
Change subject: Fix default LDAP group search filter ...................................................................... Patch Set 1: (2 comments) Hi Gergely, nice catch and thank you for submitting a fix. The change looks good, just some comments on our commit message practices. http://gerrit.cloudera.org:8080/#/c/19442/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19442/1//COMMIT_MSG@7 PS1, Line 7: Fix default LDAP group search filter Could you open a Jira for it, on this project we rarely do commits without Jiras. You might need to create an account on the apache jira and request contributor role for the Impala project. https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala http://gerrit.cloudera.org:8080/#/c/19442/1//COMMIT_MSG@9 PS1, Line 9: Due to a forgotten parenthesis, the following errors appeared in the log when trying to connect to AD: nit: the commit message line length should not exceed 72 chars. https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala -- To view, visit http://gerrit.cloudera.org:8080/19442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3fb4e9d81b5f39b5887a296579d2a9f5199acb6d Gerrit-Change-Number: 19442 Gerrit-PatchSet: 1 Gerrit-Owner: Gergely Farkas <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Thu, 26 Jan 2023 16:41:41 +0000 Gerrit-HasComments: Yes
