Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19442 )
Change subject: IMPALA-11897: Fix default LDAP group search filter ...................................................................... Patch Set 2: (2 comments) Thanks for the update Gergely, some nits, apart from that LGTM! http://gerrit.cloudera.org:8080/#/c/19442/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19442/2//COMMIT_MSG@14 PS2, Line 14: However, due to a forgotten parenthesis, the following error : appeared in the log when trying to connect to AD: : "LDAP search failed with base DN=DC=qe-ad-1,DC=cloudera,DC=com and : filter=(&(objectClass=group)(member=CN=cm-admin,CN=Users,DC=qe-ad-1, : DC=cloudera,DC=com) : Bad search filter" nit: I think this is not necessary http://gerrit.cloudera.org:8080/#/c/19442/2//COMMIT_MSG@19 PS2, Line 19: This commit fixes the incorrect group filter and solves the problem. nit: default group filter -- To view, visit http://gerrit.cloudera.org:8080/19442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3fb4e9d81b5f39b5887a296579d2a9f5199acb6d Gerrit-Change-Number: 19442 Gerrit-PatchSet: 2 Gerrit-Owner: Gergely Farkas <[email protected]> Gerrit-Reviewer: Gergely Farkas <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Tue, 07 Feb 2023 10:02:01 +0000 Gerrit-HasComments: Yes
