Xiang Yang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19110 )

Change subject: IMPALA-11629: Support for huawei OBS FileSystem
......................................................................


Patch Set 10:

(3 comments)

Thanks Michael!
I run the core test based on patch10 with only specified table-formats:

export BE_TEST=false
export FE_TEST=false
export JDBC_TEST=false
export RUN_TESTS_ARGS="--table_formats=parquet/none,kudu/none"
time bin/run-all-tests.sh -e core


the hdfs ee test log: 
https://issues.apache.org/jira/secure/attachment/13055151/hdfs_ee_test_patch10.log
the obs ee test log: 
https://issues.apache.org/jira/secure/attachment/13055152/obs_ee_test_patch10.log

When test HDFS filesystem, the HBase services are stopped.
When test OBS filesystem, the HBase and HDFS services are stopped.
Most of failed cases were failed because of hbase tables.
Some OBS failed cases can success by running with './bin/impala-py.test ...' 
manually.

http://gerrit.cloudera.org:8080/#/c/19110/9/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/19110/9/bin/impala-config.sh@710
PS9, Line 710:   export OBS_ACCESS_KEY OBS_SECRET_KEY OBS_ENDPOINT DEFAULT_FS 
ENABLE_OBS_FILESYSTEM=true
> This shouldn't need to be set. It's only used if your warehouse is not "obs
Done


http://gerrit.cloudera.org:8080/#/c/19110/9/tests/custom_cluster/test_metastore_service.py
File tests/custom_cluster/test_metastore_service.py:

http://gerrit.cloudera.org:8080/#/c/19110/9/tests/custom_cluster/test_metastore_service.py@1214
PS9, Line 1214:         if IS_HDFS or IS_OZONE:
> This should be IS_HDFS or IS_OZONE now. Probably should have updated the co
Done


http://gerrit.cloudera.org:8080/#/c/19110/9/tests/custom_cluster/test_metastore_service.py@1242
PS9, Line 1242:       if IS_HDFS or IS_OZONE:
> Same as above.
Done



--
To view, visit http://gerrit.cloudera.org:8080/19110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84a54dbebcc5b71e9bcdd141dae9e95104d98cb1
Gerrit-Change-Number: 19110
Gerrit-PatchSet: 10
Gerrit-Owner: Xiang Yang <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Xiang Yang <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Sun, 05 Feb 2023 08:27:50 +0000
Gerrit-HasComments: Yes

Reply via email to