Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19110 )

Change subject: IMPALA-11629: Support for huawei OBS FileSystem
......................................................................


Patch Set 10: Code-Review+1

> Patch Set 10:
>
> (3 comments)
>
> Thanks Michael!
> I run the core test based on patch10 with only specified table-formats:
>
> export BE_TEST=false
> export FE_TEST=false
> export JDBC_TEST=false
> export RUN_TESTS_ARGS="--table_formats=parquet/none,kudu/none"
> time bin/run-all-tests.sh -e core
>
>
> the hdfs ee test log: 
> https://issues.apache.org/jira/secure/attachment/13055151/hdfs_ee_test_patch10.log
> the obs ee test log: 
> https://issues.apache.org/jira/secure/attachment/13055152/obs_ee_test_patch10.log
>
> When test HDFS filesystem, the HBase services are stopped.
> When test OBS filesystem, the HBase and HDFS services are stopped.
> Most of failed cases were failed because of hbase tables.
> Some OBS failed cases can success by running with './bin/impala-py.test ...' 
> manually.

The changes all look right to me now. I'd have to spend some time sifting 
through the test results; there are some oddities like test_hbase_inserts fails 
with OBS but is skipped with HDFS.


--
To view, visit http://gerrit.cloudera.org:8080/19110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84a54dbebcc5b71e9bcdd141dae9e95104d98cb1
Gerrit-Change-Number: 19110
Gerrit-PatchSet: 10
Gerrit-Owner: Xiang Yang <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Xiang Yang <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Mon, 06 Feb 2023 17:15:00 +0000
Gerrit-HasComments: No

Reply via email to