Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19474 )
Change subject: IMPALA-11803: Impalad hit DCHECK when running union on empty table with MT_DOP>1 ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/19474/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19474/2//COMMIT_MSG@7 PS2, Line 7: Impalad hit DCHECK when running union on : empty table with MT_DOP>1 nit: we'd better summarize how the issue is fixed instead of describing the issue. http://gerrit.cloudera.org:8080/#/c/19474/2//COMMIT_MSG@11 PS2, Line 11: nit: no space at line start http://gerrit.cloudera.org:8080/#/c/19474/2/tests/custom_cluster/test_mt_dop.py File tests/custom_cluster/test_mt_dop.py: http://gerrit.cloudera.org:8080/#/c/19474/2/tests/custom_cluster/test_mt_dop.py@68 PS2, Line 68: def test_mt_dop_union_empty_table(self, unique_database): Please verify the test failed without the fix. I think it won't fail since the following annotation is missing here: @CustomClusterTestSuite.with_args(cluster_size=1) http://gerrit.cloudera.org:8080/#/c/19474/2/tests/custom_cluster/test_mt_dop.py@73 PS2, Line 73: self.client.execute("create table {0}.tbl (id int) stored as parquet" : .format(unique_database)) : self.client.execute("insert into {0}.tbl values (0), (1), (2)" : .format(unique_database)) We can use an existing table (e.g. functional.alltypestiny) instead of creating a new one. -- To view, visit http://gerrit.cloudera.org:8080/19474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbae5e1a78211327a214b2d936743bda767ae3c4 Gerrit-Change-Number: 19474 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 06 Feb 2023 09:04:39 +0000 Gerrit-HasComments: Yes
