Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19474 )
Change subject: IMPALA-11803: Impalad hit DCHECK when running union on empty table with MT_DOP>1 ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/19474/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19474/2//COMMIT_MSG@7 PS2, Line 7: Impalad hit DCHECK when running union on : empty table with MT_DOP>1 > I've updated the description, should I change the title of the jira as well No, we just need to change the commit title. The JIRA title is ok to just describe the problem. The commit title would be nice to focus on how the issue is fixed, e.g. "Fix hitting DCHECK when running union on empty table with MT_DOP>1" BTW, the title should be in one line. http://gerrit.cloudera.org:8080/#/c/19474/2//COMMIT_MSG@11 PS2, Line 11: w > Done Not done yet in other lines.. http://gerrit.cloudera.org:8080/#/c/19474/3/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/19474/3/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@2095 PS3, Line 2095: useMtScanNode_ = queryOptions.mt_dop > 0; Could you add a comment like this? So we won't make the same mistake when adding codes in the future. // update 'useMtScanNode_' before any return cases. It's used in BE. -- To view, visit http://gerrit.cloudera.org:8080/19474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbae5e1a78211327a214b2d936743bda767ae3c4 Gerrit-Change-Number: 19474 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 15 Feb 2023 08:56:47 +0000 Gerrit-HasComments: Yes
