Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19492 )
Change subject: IMPALA-11912: Inline base::IsAarch64 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/19492/1/be/src/gutil/sysinfo.h File be/src/gutil/sysinfo.h: http://gerrit.cloudera.org:8080/#/c/19492/1/be/src/gutil/sysinfo.h@69 PS1, Line 69: IsAarch64( nit: Could you add a comment so that we wouldn't lose this change when upgrade gutil in future. -- To view, visit http://gerrit.cloudera.org:8080/19492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6d62de63a0cb7b94244a1d4f8dcc6b2e65b6d9c Gerrit-Change-Number: 19492 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 13 Feb 2023 05:28:39 +0000 Gerrit-HasComments: Yes
