Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19492 )
Change subject: IMPALA-11916: Replace base::IsAarch64 with constant ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19492/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19492/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-11916 > nit: Should this be IMPALA-11916 instead? Oops! Thanks for catching this! http://gerrit.cloudera.org:8080/#/c/19492/1/be/src/gutil/sysinfo.h File be/src/gutil/sysinfo.h: http://gerrit.cloudera.org:8080/#/c/19492/1/be/src/gutil/sysinfo.h@69 PS1, Line 69: #ifndef _S > nit: Could you add a comment so that we wouldn't lose this change when upgr Oh, just realized this file comes from gutil. This method is added in IMPALA-. It's simple enough to be replaced by a IS_AARCH64 constant. Added the constant in cpu-info.h instead. -- To view, visit http://gerrit.cloudera.org:8080/19492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6d62de63a0cb7b94244a1d4f8dcc6b2e65b6d9c Gerrit-Change-Number: 19492 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 14 Feb 2023 01:08:26 +0000 Gerrit-HasComments: Yes
