Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )
Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables ...................................................................... Patch Set 33: (2 comments) Thanks to fix the issue for non unique primary key. It looks good to me, only a few nits. http://gerrit.cloudera.org:8080/#/c/18729/33/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18729/33/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3934 PS33, Line 3934: assigned nit: created http://gerrit.cloudera.org:8080/#/c/18729/33/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3940 PS33, Line 3940: List<String> primaryColumnNames = new ArrayList<>(); : for (String primaryColumnName : kuduTable.getPrimaryKeyColumnNames()) { : if (KuduUtil.getAutoIncrementingColumnName().equals(primaryColumnName)) continue; : primaryColumnNames.add(primaryColumnName); : } nit: a little optimization to avoid checking auto-incrementing column for table with unique key. List<String> primaryColumnNames = new ArrayList(kuduTable.getPrimaryKeyColumnNames()); if (kuduTable.hasAutoIncrementingColumn()) { primaryColumnNames.remove(KuduUtil.getAutoIncrementingColumnName()); } -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 33 Gerrit-Owner: Xiaoqing Gao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Xiaoqing Gao <[email protected]> Gerrit-Comment-Date: Wed, 15 Feb 2023 18:20:23 +0000 Gerrit-HasComments: Yes
