Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )
Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables ...................................................................... Patch Set 33: (2 comments) http://gerrit.cloudera.org:8080/#/c/18729/33/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18729/33/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3934 PS33, Line 3934: assigned > nit: created Done http://gerrit.cloudera.org:8080/#/c/18729/33/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3940 PS33, Line 3940: List<String> primaryColumnNames = new ArrayList<>(); : for (String primaryColumnName : kuduTable.getPrimaryKeyColumnNames()) { : if (KuduUtil.getAutoIncrementingColumnName().equals(primaryColumnName)) continue; : primaryColumnNames.add(primaryColumnName); : } > nit: a little optimization to avoid checking auto-incrementing column for t Done -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 33 Gerrit-Owner: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Comment-Date: Thu, 16 Feb 2023 04:12:53 +0000 Gerrit-HasComments: Yes
