Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 )
Change subject: IMPALA-11223: Use unique id to create codegen instances ...................................................................... Patch Set 1: Code-Review+1 This seems fine to me. I don't see any use of the ID outside of writing to disk for debugging. Adding Yida since he's been deep in codegen recently. -- To view, visit http://gerrit.cloudera.org:8080/19505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7672906365c916bbe750eeb9906cab38573e6c31 Gerrit-Change-Number: 19505 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 16 Feb 2023 17:59:56 +0000 Gerrit-HasComments: No
