Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 )
Change subject: IMPALA-11223: Use unique id to create codegen instances ...................................................................... Patch Set 1: > Patch Set 1: > > Thanks Quanlong, this seems good to me. > > I wonder if this solves a problem I've come across a few times in the past: > when I was looking for a codegen'd function in the unoptimised llvm bitcode, > sometimes when I ran the same query several times, the function only showed > up in about 1 case out of 5. Do you think it's possible that the output file > was overwritten by another fragment? Or is this change only relevant for the > asm output? Yeah, thanks for sharing this! The id is also used in dumping IRs: https://github.com/apache/impala/blob/d0592c0dbf4d634cc26b2e9872a9f62af5249cdd/be/src/codegen/llvm-codegen.cc#L1258 https://github.com/apache/impala/blob/d0592c0dbf4d634cc26b2e9872a9f62af5249cdd/be/src/codegen/llvm-codegen.cc#L1324 So this patch will also fix the issue you encountered. I'll update the comments about this. -- To view, visit http://gerrit.cloudera.org:8080/19505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7672906365c916bbe750eeb9906cab38573e6c31 Gerrit-Change-Number: 19505 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Sun, 26 Feb 2023 01:46:39 +0000 Gerrit-HasComments: No
