Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19524 )
Change subject: IMPALA-10111: Fix TestWebPage::test_query_stmt is flakiness ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Thanks for fixing this! http://gerrit.cloudera.org:8080/#/c/19524/3/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/19524/3/tests/webserver/test_web_pages.py@496 PS3, Line 496: nit: the indentation looks weird. Can we keep 4 spaces identation? We might need to wrap the first parameter to the next line: response_json = self.__run_query_and_get_debug_page( query, self.QUERIES_URL, expected_state=self.client.QUERY_STATES["FINISHED"]) -- To view, visit http://gerrit.cloudera.org:8080/19524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If25d430a871415a3884dece772b8d8105c583c05 Gerrit-Change-Number: 19524 Gerrit-PatchSet: 3 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Tue, 21 Feb 2023 12:04:18 +0000 Gerrit-HasComments: Yes
