Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19524 )
Change subject: IMPALA-10111: Fix TestWebPage::test_query_stmt flakiness ...................................................................... Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/19524/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19524/5//COMMIT_MSG@7 PS5, Line 7: is > Nit: no need for 'is'. Done http://gerrit.cloudera.org:8080/#/c/19524/5//COMMIT_MSG@9 PS5, Line 9: someimes > Nit: sometimes. Done http://gerrit.cloudera.org:8080/#/c/19524/5//COMMIT_MSG@10 PS5, Line 10: filters out duplicates > I'm not sure it is easily understandable. Is the situation that the query i Its independent of the number of executions. In both cases the query/queries still can be in in_flight_qeries for a while. I don't know if this is intended, or not, I did not dig deep in it, just wanted to fix the flakiness. http://gerrit.cloudera.org:8080/#/c/19524/5//COMMIT_MSG@11 PS5, Line 11: outputing > Nit: outputting. Done http://gerrit.cloudera.org:8080/#/c/19524/5//COMMIT_MSG@13 PS5, Line 13: exection > Nit: execution? I think so, there is no point executing it multiple times. One was a direct execute_query call, the other is __run_query_and_get_debug_page, just executes and retrieves the web info, so the first execution is not necessary. http://gerrit.cloudera.org:8080/#/c/19524/5//COMMIT_MSG@14 PS5, Line 14: response to ease debugging in the future. > Can you clarify how the flakiness is fixed? Is it by also searching in resp Done -- To view, visit http://gerrit.cloudera.org:8080/19524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If25d430a871415a3884dece772b8d8105c583c05 Gerrit-Change-Number: 19524 Gerrit-PatchSet: 5 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Mon, 27 Feb 2023 10:26:33 +0000 Gerrit-HasComments: Yes
