Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19550 )
Change subject: IMPALA-11951: Add tools for checking/fixing python 3 syntax ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/19550/2/bin/check-python-syntax.sh File bin/check-python-syntax.sh: http://gerrit.cloudera.org:8080/#/c/19550/2/bin/check-python-syntax.sh@25 PS2, Line 25: for file in $(git ls-files | grep '\.py$'); do This and excluding specific patterns could also be accomplished with git file patterns > git ls-files '**/*.py' ':!:shell/ext-py/' ':!:shell/pkg_resources.py' http://gerrit.cloudera.org:8080/#/c/19550/2/bin/check-python-syntax.sh@28 PS2, Line 28: continue nit: inconsistent indentation. http://gerrit.cloudera.org:8080/#/c/19550/2/bin/check-python-syntax.sh@48 PS2, Line 48: rm "${file}c" nit: inconsistent indentation -- To view, visit http://gerrit.cloudera.org:8080/19550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae2c51bc6ddc9b6a04469ee1b8284227fed3bd45 Gerrit-Change-Number: 19550 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 27 Feb 2023 21:34:31 +0000 Gerrit-HasComments: Yes
