Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19550 )
Change subject: IMPALA-11951: Add tools for checking/fixing python 3 syntax ...................................................................... IMPALA-11951: Add tools for checking/fixing python 3 syntax This adds the bin/check-python-syntax.sh script, which runs "python -m compileall" for all python files in Impala with both python2 and python3. This detects syntax errors in the python files. This will be incorporated into precommit once it is clean. This also adds future to the impala-python virtualenv. This provides the futurize script (exposed via impala-futurize), which can be used to automatically fix some py2/py3 issues. Future also provides the builtins library, which can provide python 3 functionality on python 2. Testing: - Ran impala-futurize locally - Ran the script repeatedly while fixing syntax errors Change-Id: Iae2c51bc6ddc9b6a04469ee1b8284227fed3bd45 Reviewed-on: http://gerrit.cloudera.org:8080/19550 Reviewed-by: Michael Smith <[email protected]> Tested-by: Michael Smith <[email protected]> --- A bin/check-python-syntax.sh A bin/impala-futurize M infra/python/deps/requirements.txt 3 files changed, 93 insertions(+), 0 deletions(-) Approvals: Michael Smith: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/19550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iae2c51bc6ddc9b6a04469ee1b8284227fed3bd45 Gerrit-Change-Number: 19550 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
