Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19511 )
Change subject: IMPALA-10861: Optimize the plan for identical predicates ...................................................................... Patch Set 2: (7 comments) Thanks Baike for the fix. http://gerrit.cloudera.org:8080/#/c/19511/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19511/2//COMMIT_MSG@9 PS2, Line 9: For hes query with two same predicates, duplicate data is deleted. Would be good to elaborate the comment on what the current issue is and how the solution is like. http://gerrit.cloudera.org:8080/#/c/19511/2//COMMIT_MSG@9 PS2, Line 9: duplicate nit. duplicated http://gerrit.cloudera.org:8080/#/c/19511/2//COMMIT_MSG@9 PS2, Line 9: hes nit. the? http://gerrit.cloudera.org:8080/#/c/19511/2//COMMIT_MSG@12 PS2, Line 12: a.id = b.id and a.id and b.id Would it also work for below cases? a.id = b.id and b.id = a.id a.num > b.num and b.num <= a.num http://gerrit.cloudera.org:8080/#/c/19511/2//COMMIT_MSG@12 PS2, Line 12: a.id and b.id should be a.id = b.id? http://gerrit.cloudera.org:8080/#/c/19511/2/testdata/workloads/functional-planner/queries/PlannerTest/joins.test File testdata/workloads/functional-planner/queries/PlannerTest/joins.test: http://gerrit.cloudera.org:8080/#/c/19511/2/testdata/workloads/functional-planner/queries/PlannerTest/joins.test@3118 PS2, Line 3118: duplicate nit. duplicated http://gerrit.cloudera.org:8080/#/c/19511/2/testdata/workloads/functional-planner/queries/PlannerTest/joins.test@3118 PS2, Line 3118: hes nit. the? -- To view, visit http://gerrit.cloudera.org:8080/19511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia249c8146215fad602e9310bf922c6bfa050b96b Gerrit-Change-Number: 19511 Gerrit-PatchSet: 2 Gerrit-Owner: Baike Xia <[email protected]> Gerrit-Reviewer: Baike Xia <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 06 Mar 2023 02:50:34 +0000 Gerrit-HasComments: Yes
