Baike Xia has posted comments on this change. ( http://gerrit.cloudera.org:8080/19511 )
Change subject: IMPALA-10861: Optimize the plan for identical predicates ...................................................................... Patch Set 3: (7 comments) > Patch Set 2: > > (7 comments) > > Thanks Baike for the fix. Hi Yida, Thanks for your advice and reply. I made some fixes in response to your suggestions. Looking forward to your reply and CR. http://gerrit.cloudera.org:8080/#/c/19511/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19511/2//COMMIT_MSG@9 PS2, Line 9: For the query with two same predicates, duplicated data is deleted > Would be good to elaborate the comment on what the current issue is and how OK, I'm going to optimize this description. http://gerrit.cloudera.org:8080/#/c/19511/2//COMMIT_MSG@9 PS2, Line 9: the > nit. the? Done http://gerrit.cloudera.org:8080/#/c/19511/2//COMMIT_MSG@9 PS2, Line 9: duplicate > nit. duplicated Done http://gerrit.cloudera.org:8080/#/c/19511/2//COMMIT_MSG@12 PS2, Line 12: ing. > Would it also work for below cases? Done http://gerrit.cloudera.org:8080/#/c/19511/2//COMMIT_MSG@12 PS2, Line 12: > should be a.id = b.id? Done http://gerrit.cloudera.org:8080/#/c/19511/2/testdata/workloads/functional-planner/queries/PlannerTest/joins.test File testdata/workloads/functional-planner/queries/PlannerTest/joins.test: http://gerrit.cloudera.org:8080/#/c/19511/2/testdata/workloads/functional-planner/queries/PlannerTest/joins.test@3118 PS2, Line 3118: the > nit. the? Done http://gerrit.cloudera.org:8080/#/c/19511/2/testdata/workloads/functional-planner/queries/PlannerTest/joins.test@3118 PS2, Line 3118: duplicate > nit. duplicated Done -- To view, visit http://gerrit.cloudera.org:8080/19511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia249c8146215fad602e9310bf922c6bfa050b96b Gerrit-Change-Number: 19511 Gerrit-PatchSet: 3 Gerrit-Owner: Baike Xia <[email protected]> Gerrit-Reviewer: Baike Xia <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 20 Mar 2023 17:30:17 +0000 Gerrit-HasComments: Yes
