Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19567 )
Change subject: IMPALA-11959: Add Python 3 virtualenv ...................................................................... Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/19567/4/bin/banned_py3k_warnings.txt File bin/banned_py3k_warnings.txt: PS4: Can you mention why this file exists in the commit message as well? It just mentions "a mechanism". http://gerrit.cloudera.org:8080/#/c/19567/4/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: http://gerrit.cloudera.org:8080/#/c/19567/4/infra/python/bootstrap_virtualenv.py@113 PS4, Line 113: # Python 3 is much simpler, because there is a builtin venv command Could we switch to using this for both? I guess we'd have to guarantee python3 is downloaded before setting up python2. -- To view, visit http://gerrit.cloudera.org:8080/19567 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica4853f440c9a46a79bd5fb8e0a66730b0b4efc0 Gerrit-Change-Number: 19567 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 07 Mar 2023 19:38:20 +0000 Gerrit-HasComments: Yes
