Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19567 )
Change subject: IMPALA-11959: Add Python 3 virtualenv ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/19567/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19567/4//COMMIT_MSG@36 PS4, Line 36: This pulls in a new toolchain with the fix for IMPALA-11956 : to get Python 3.7.16. The IMPALA-11956 patch has been merged, so the new upload now uses a toolchain built against later native-toolchain master with IMPALA-11956. http://gerrit.cloudera.org:8080/#/c/19567/4/bin/banned_py3k_warnings.txt File bin/banned_py3k_warnings.txt: PS4: > Can you mention why this file exists in the commit message as well? It just Yes, will do http://gerrit.cloudera.org:8080/#/c/19567/4/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: http://gerrit.cloudera.org:8080/#/c/19567/4/infra/python/bootstrap_virtualenv.py@113 PS4, Line 113: # Python 3 is much simpler, because there is a builtin venv command > Could we switch to using this for both? I guess we'd have to guarantee pyth I don't think it is possible to use python 3 venv to produce a python 2 virtual env. The virtualenv includes a link to the python that created it under bin and uses that python for everything. -- To view, visit http://gerrit.cloudera.org:8080/19567 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica4853f440c9a46a79bd5fb8e0a66730b0b4efc0 Gerrit-Change-Number: 19567 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 08 Mar 2023 19:39:22 +0000 Gerrit-HasComments: Yes
