Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19628 )
Change subject: IMPALA-12005: Describe executor group set selection in query profile ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/19628/4/be/src/util/runtime-profile.h File be/src/util/runtime-profile.h: http://gerrit.cloudera.org:8080/#/c/19628/4/be/src/util/runtime-profile.h@315 PS4, Line 315: RuntimeProfileBase(ObjectPool* pool, const std::string& name, : Counter* total_time_counter, Counter* inactive_timer); : RuntimeProfileBase(ObjectPool* pool, const std::string& name, : Counter* total_time_counter, Counter* inactive_timer, bool add_default_counters); We could combine two overloaded functions as one by defining the default value of "add_default_counters" as true. http://gerrit.cloudera.org:8080/#/c/19628/4/fe/src/main/java/org/apache/impala/service/FrontendProfile.java File fe/src/main/java/org/apache/impala/service/FrontendProfile.java: http://gerrit.cloudera.org:8080/#/c/19628/4/fe/src/main/java/org/apache/impala/service/FrontendProfile.java@187 PS4, Line 187: Preconditions.checkState(profile_ != null, "already emitted profile"); it's already called in addToCounter() and setToCounter() -- To view, visit http://gerrit.cloudera.org:8080/19628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c0ac7f5216d631e4439fe97702e21e06d2eda8a Gerrit-Change-Number: 19628 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Sun, 19 Mar 2023 07:24:34 +0000 Gerrit-HasComments: Yes
