David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/19628 )
Change subject: IMPALA-12005: Describe executor group set selection in query profile ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/19628/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/19628/1/fe/src/main/java/org/apache/impala/service/Frontend.java@245 PS1, Line 245: private static final String EXECUTOR_GROUP_CONSIDERED = "ExecutorGroupConsidered"; Nit: Make plural - "ExecutorGroupsConsidered" http://gerrit.cloudera.org:8080/#/c/19628/1/fe/src/main/java/org/apache/impala/service/Frontend.java@2102 PS1, Line 2102: FrontendProfile.getCurrent().setToCounter( : EFFECTIVE_PARALLELISM, TUnit.UNIT, cores_requirement); Since the Effective Parallelism can vary for each group set/replan, maybe it would be better to add this as a counter to each groupSetProfile so the values get displayed separately for each group? We already do that for CpuAsk so maybe it's redundant to print both for each group but overall I think it would be clearer. The current approach of just printing EffectiveParallelism once at the top suggests that the value is the same for all groups which is misleading. -- To view, visit http://gerrit.cloudera.org:8080/19628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c0ac7f5216d631e4439fe97702e21e06d2eda8a Gerrit-Change-Number: 19628 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 16 Mar 2023 23:13:37 +0000 Gerrit-HasComments: Yes
