Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19651 )
Change subject: IMPALA-11985: [DOCS] Support for Kudu's multi-rows transaction ...................................................................... Patch Set 1: (17 comments) http://gerrit.cloudera.org:8080/#/c/19651/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19651/1//COMMIT_MSG@7 PS1, Line 7: multi-rows transaction nit: multi-row transactions http://gerrit.cloudera.org:8080/#/c/19651/1//COMMIT_MSG@9 PS1, Line 9: multi-rows transaction nit: multi-row transactions http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml File docs/topics/impala_kudu.xml: http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1399 PS1, Line 1399: multi-row nit: Multi-row http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1401 PS1, Line 1401: Using this multi-row transaction capability, you will benefit from having broader : transactional support in Kudu and Impala. This sentence looks like a marketing piece, IMO. I don't see what useful information this brings into the docs. http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1403 PS1, Line 1403: or per-session : level. What does this do on per-session level, i.e. what's the semantics of a transactional Impala session when working with Kudu tables? And is there a transactional Impala session in that sense at all? How is that different from per-query option? http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1420 PS1, Line 1420: <p>If you insert multiple rows with duplicate keys into a table the transaction is aborted. To add a comma after 'table'? http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1424 PS1, Line 1424: When you enable this option What option? --kudu_ignore_conflicts_in_transaction or ENABLE_KUDU_TRANSACTION? http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1424 PS1, Line 1424: impala Impala http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1425 PS1, Line 1425: add comma after 'successfully'? http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1436 PS1, Line 1436: this nit: This (or update the rest of the sentence to use small letters except for the very first word) http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1441 PS1, Line 1441: Atomically do a bulk ingest How to do atomic bulk ingest into Kudu tables using current Impala support for multi-row transactions? Could you provide a recipe for that? http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1442 PS1, Line 1442: Automatically Atomically? http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1442 PS1, Line 1442: insert rows into multiple tables How is that achievable with current support for multi-row Kudu transactions from Impala side? I.e., could you provide a recipe for doing that? http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1448 PS1, Line 1448: multiple-rows multi-row http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1448 PS1, Line 1448: but does not : support UPDATE/UPSERT/DELETE statements now Consider updating this to something like: INSERT and CTAS statements are supported for Kudu tables in the context of a multi-row transaction, but UPDATE/UPSERT/DELETE statements cannot be a part of a multi-row transaction as of now. http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1451 PS1, Line 1451: nit: extra trailing spaces http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1464 PS1, Line 1464: multi-row multiple rows -- To view, visit http://gerrit.cloudera.org:8080/19651 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic226679d83d7221f843994ead11cb2bc9e971882 Gerrit-Change-Number: 19651 Gerrit-PatchSet: 1 Gerrit-Owner: Shajini Thayasingh <sthayasi...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Fri, 24 Mar 2023 21:26:21 +0000 Gerrit-HasComments: Yes
