Shajini Thayasingh has posted comments on this change. ( http://gerrit.cloudera.org:8080/19651 )
Change subject: IMPALA-11985: [DOCS] Support for Kudu's multi-rows transaction ...................................................................... Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml File docs/topics/impala_kudu.xml: http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1399 PS1, Line 1399: Multi-row > nit: Multi-row Done http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1420 PS1, Line 1420: <p>If you insert multiple rows with duplicate keys into a table, the transaction is aborted. > add a comma after 'table'? Done http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1425 PS1, Line 1425: m > add comma after 'successfully'? Done http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1436 PS1, Line 1436: This > nit: This (or update the rest of the sentence to use small letters except f Done http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1442 PS1, Line 1442: > This line should be removed. Done http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1448 PS1, Line 1448: t UPDATE/UPSE > multi-row This is taken care of as part of the next comment. http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1448 PS1, Line 1448: ti-row transaction : as of now.</p></conbody> > Consider updating this to something like: Done http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1451 PS1, Line 1451: > nit: extra trailing spaces Done http://gerrit.cloudera.org:8080/#/c/19651/1/docs/topics/impala_kudu.xml@1464 PS1, Line 1464: multiple > multiple rows Done -- To view, visit http://gerrit.cloudera.org:8080/19651 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic226679d83d7221f843994ead11cb2bc9e971882 Gerrit-Change-Number: 19651 Gerrit-PatchSet: 2 Gerrit-Owner: Shajini Thayasingh <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Shajini Thayasingh <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 24 Mar 2023 23:07:38 +0000 Gerrit-HasComments: Yes
