Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/19583 )
Change subject: IMPALA-11970: Add query timeline display to Impala WebUI ...................................................................... Patch Set 6: (10 comments) http://gerrit.cloudera.org:8080/#/c/19583/6/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/19583/6/www/query_timeline.tmpl@183 PS6, Line 183: en++ > nit: ++en to keep consistent with other for loop Done http://gerrit.cloudera.org:8080/#/c/19583/6/www/query_timeline.tmpl@214 PS6, Line 214: + > nit: space around two '+' in this line Done http://gerrit.cloudera.org:8080/#/c/19583/6/www/query_timeline.tmpl@230 PS6, Line 230: - > nit: space around '-' Done http://gerrit.cloudera.org:8080/#/c/19583/6/www/query_timeline.tmpl@232 PS6, Line 232: - > nit: space around '-' Done http://gerrit.cloudera.org:8080/#/c/19583/6/www/query_timeline.tmpl@241 PS6, Line 241: en++ > nit: ++en to keep consistent with other for loop Done http://gerrit.cloudera.org:8080/#/c/19583/6/www/query_timeline.tmpl@300 PS6, Line 300: + > nit: space around two '+' in this line Done http://gerrit.cloudera.org:8080/#/c/19583/6/www/query_timeline.tmpl@306 PS6, Line 306: en++ > nit: ++en to keep consistent with other for loop Done http://gerrit.cloudera.org:8080/#/c/19583/6/www/query_timeline.tmpl@324 PS6, Line 324: + > nit: space around two '+' in this line Done http://gerrit.cloudera.org:8080/#/c/19583/6/www/query_timeline.tmpl@341 PS6, Line 341: / > nit: space around '/' Done http://gerrit.cloudera.org:8080/#/c/19583/6/www/query_timeline.tmpl@418 PS6, Line 418: height/2+3 > nit: space around '/' and '+' Done -- To view, visit http://gerrit.cloudera.org:8080/19583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b5826107af0f5a7fe306cb986a875cff261d9db Gerrit-Change-Number: 19583 Gerrit-PatchSet: 6 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 31 Mar 2023 19:46:54 +0000 Gerrit-HasComments: Yes
