Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/19583 )
Change subject: IMPALA-11970: Add query timeline display to Impala WebUI ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/19583/7/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/19583/7/be/src/service/impala-http-handler.cc@348 PS7, Line 348: if (!status.ok()) { : Value error(ss.str().c_str(), document->GetAllocator()); : document->AddMember("error", error, document->GetAllocator()); : return; : } > This changes the behavior not to return profile if WebRequest does not have Done http://gerrit.cloudera.org:8080/#/c/19583/7/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/19583/7/be/src/util/runtime-profile.cc@1230 PS7, Line 1230: content > contents Done -- To view, visit http://gerrit.cloudera.org:8080/19583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b5826107af0f5a7fe306cb986a875cff261d9db Gerrit-Change-Number: 19583 Gerrit-PatchSet: 7 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 06 Apr 2023 19:33:44 +0000 Gerrit-HasComments: Yes
