Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18023 )
Change subject: IMPALA-7942 (part 2): Add query hints for predicate selectivities ...................................................................... Patch Set 27: Code-Review+1 (8 comments) Looks great. Just have some minor comments on the commit message. http://gerrit.cloudera.org:8080/#/c/18023/27//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18023/27//COMMIT_MSG@9 PS27, Line 9: Currently, Impala only uses simple estimation to compute selectivity nit. stop the sentence here (.) http://gerrit.cloudera.org:8080/#/c/18023/27//COMMIT_MSG@10 PS27, Line 10: for some predicates, and this may lead nit. For some predicates, this may lead to ... http://gerrit.cloudera.org:8080/#/c/18023/27//COMMIT_MSG@11 PS27, Line 11: Hence, we add new hints to reduce such errors. nit. The next sentence at line 13 mentions the specific work done in this patch. I think we can remove this sentence. http://gerrit.cloudera.org:8080/#/c/18023/27//COMMIT_MSG@13 PS27, Line 13: s nit. hint. http://gerrit.cloudera.org:8080/#/c/18023/27//COMMIT_MSG@14 PS27, Line 14: original selectivity computing nit. specify a selectivity value for a predicate. http://gerrit.cloudera.org:8080/#/c/18023/27//COMMIT_MSG@17 PS27, Line 17: C-style /* comment */ nit. C-style comment /* <predicate hint> */ http://gerrit.cloudera.org:8080/#/c/18023/27//COMMIT_MSG@17 PS27, Line 17: currently : supports nit. can be in the form of http://gerrit.cloudera.org:8080/#/c/18023/27//COMMIT_MSG@25 PS27, Line 25: Predicate Example nit. predicate example -- To view, visit http://gerrit.cloudera.org:8080/18023 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2776b9bbd878b8a21d9c866b400140a454f59e1b Gerrit-Change-Number: 18023 Gerrit-PatchSet: 27 Gerrit-Owner: wangsheng <sky...@163.com> Gerrit-Reviewer: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qfc...@hotmail.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Xiang Yang <yx91...@126.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Sun, 02 Apr 2023 13:29:08 +0000 Gerrit-HasComments: Yes
