wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18023 )
Change subject: IMPALA-7942 (part 2): Add query hints for predicate selectivities ...................................................................... Patch Set 28: (8 comments) Thanks for review, Qifan. http://gerrit.cloudera.org:8080/#/c/18023/27//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18023/27//COMMIT_MSG@9 PS27, Line 9: Currently, Impala only uses simple estimation to compute selectivity. > nit. stop the sentence here (.) Done http://gerrit.cloudera.org:8080/#/c/18023/27//COMMIT_MSG@10 PS27, Line 10: For some predicates, this may lead to > nit. Done http://gerrit.cloudera.org:8080/#/c/18023/27//COMMIT_MSG@11 PS27, Line 11: > nit. The next sentence at line 13 mentions the specific work done in this p Done http://gerrit.cloudera.org:8080/#/c/18023/27//COMMIT_MSG@13 PS27, Line 13: l > nit. hint. Done http://gerrit.cloudera.org:8080/#/c/18023/27//COMMIT_MSG@14 PS27, Line 14: > nit. specify a selectivity value for a predicate. Done http://gerrit.cloudera.org:8080/#/c/18023/27//COMMIT_MSG@17 PS27, Line 17: predicate hint curren > nit. C-style comment /* <predicate hint> */ Done http://gerrit.cloudera.org:8080/#/c/18023/27//COMMIT_MSG@17 PS27, Line 17: where : 'f' is a > nit. can be in the form of Done http://gerrit.cloudera.org:8080/#/c/18023/27//COMMIT_MSG@25 PS27, Line 25: predicate example > nit. predicate example Done -- To view, visit http://gerrit.cloudera.org:8080/18023 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2776b9bbd878b8a21d9c866b400140a454f59e1b Gerrit-Change-Number: 18023 Gerrit-PatchSet: 28 Gerrit-Owner: wangsheng <sky...@163.com> Gerrit-Reviewer: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qfc...@hotmail.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Xiang Yang <yx91...@126.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Mon, 03 Apr 2023 07:39:03 +0000 Gerrit-HasComments: Yes
