Wenzhe Zhou has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19688 )
Change subject: IMPALA-12036: Fix Web UI to show right resource pools ...................................................................... IMPALA-12036: Fix Web UI to show right resource pools Web UI always shows default resource pool even if a different resource pool is used by the query. The Planner could set TQueryCtx.request_pool in TQueryExecRequest when auto scaling is enabled. But the backend ignores the TQueryCtx.request_pool in TQueryExecRequest when getting resource pools for Web UI. This patch fixs the issue in ClientRequestState::request_pool() by checking TQueryCtx.request_pool in TQueryExecRequest. It also removes the error path in RequestPoolService::ResolveRequestPool() if requested_pool is empty string. Testing: - Updated TestExecutorGroups::test_query_cpu_count_divisor_default, TestExecutorGroups::test_query_cpu_count_divisor_two, and TestExecutorGroups::test_query_cpu_count_divisor_fraction to verify resource pools on Web queries site and Web admission site. - Updated expected error message in TestAdmissionController::test_set_request_pool. - Passed core test. Change-Id: Iceacb3a8ec3bd15a8029ba05d064bbbb81e3a766 --- M be/src/scheduling/request-pool-service.cc M be/src/service/client-request-state.h M tests/custom_cluster/test_admission_controller.py M tests/custom_cluster/test_executor_groups.py M tests/custom_cluster/test_web_pages.py 5 files changed, 44 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/19688/3 -- To view, visit http://gerrit.cloudera.org:8080/19688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iceacb3a8ec3bd15a8029ba05d064bbbb81e3a766 Gerrit-Change-Number: 19688 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]>
