Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19688 )
Change subject: IMPALA-12036: Fix Web UI to show right resource pools ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/19688/4/be/src/scheduling/request-pool-service.cc File be/src/scheduling/request-pool-service.cc: http://gerrit.cloudera.org:8080/#/c/19688/4/be/src/scheduling/request-pool-service.cc@a181 PS4, Line 181: Does this constant still being used somewhere? Can it be removed? Also, does removing this condition change any behavior? Any test that is changing? What happen now if result.resolved_pool.empty() is true? Does the method documentation in request-pool-service.h need update as well? http://gerrit.cloudera.org:8080/#/c/19688/4/be/src/service/client-request-state.h File be/src/service/client-request-state.h: http://gerrit.cloudera.org:8080/#/c/19688/4/be/src/service/client-request-state.h@256 PS4, Line 256: return exec_request_->query_exec_request.query_ctx.__isset.request_pool ? : exec_request_->query_exec_request.query_ctx.request_pool : : (query_ctx_.__isset.request_pool ? query_ctx_.request_pool : ""); nit: Can we change this to if-else and comments for better readability? http://gerrit.cloudera.org:8080/#/c/19688/4/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/19688/4/tests/custom_cluster/test_executor_groups.py@931 PS4, Line 931: # Check resource pools on the Web queries site and admission site : self._verify_query_num_for_resource_pool("root.small", 2) : self._verify_query_num_for_resource_pool("root.tiny", 1) : self._verify_query_num_for_resource_pool("root.large", 2) : self._verify_total_admitted_queries("root.small", 2) : self._verify_total_admitted_queries("root.tiny", 1) : self._verify_total_admitted_queries("root.large", 2) nit: move this right after _setup_three_exec_group_cluster in line 891. If verify fail, then no testcase should be run. Similarly for the other 2 below. -- To view, visit http://gerrit.cloudera.org:8080/19688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iceacb3a8ec3bd15a8029ba05d064bbbb81e3a766 Gerrit-Change-Number: 19688 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 04 Apr 2023 18:31:48 +0000 Gerrit-HasComments: Yes
