Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19697 )
Change subject: IMPALA-9627: Update utility scripts for Python 3 (part 2) ...................................................................... Patch Set 5: (1 comment) I'm ok with making our scripts compatible with both python2 and python3. For scripts that are only for development, we also have the option of requiring python3 and switching to python3-only if that is easier. One overarching comment: If we are going to add "from __future__ import absolute_import" to a bunch of files, then we should go ahead and add these three together: from __future__ import absolute_import, division, print_function Optionally unicode_literals (if it works). http://gerrit.cloudera.org:8080/#/c/19697/3/tests/comparison/data_generator_reducer.py File tests/comparison/data_generator_reducer.py: http://gerrit.cloudera.org:8080/#/c/19697/3/tests/comparison/data_generator_reducer.py@36 PS3, Line 36: from __future__ import absolute_import > I don't think I can address this. It's a weird file that starts in bash the That's fine. This is a weird file. -- To view, visit http://gerrit.cloudera.org:8080/19697 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idff388aff33817b0629347f5843ec34c78f0d0cb Gerrit-Change-Number: 19697 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 14 Apr 2023 00:13:47 +0000 Gerrit-HasComments: Yes
