Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19697 )
Change subject: IMPALA-9627: Update utility scripts for Python 3 (part 2) ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/19697/5/bin/check-pylint-py3k.sh File bin/check-pylint-py3k.sh: http://gerrit.cloudera.org:8080/#/c/19697/5/bin/check-pylint-py3k.sh@a77 PS5, Line 77: : : : I think scripts that are already using python3-only can skip these py3k checks. We don't care about running them with python2. http://gerrit.cloudera.org:8080/#/c/19697/5/bin/resolve_minidumps.py File bin/resolve_minidumps.py: http://gerrit.cloudera.org:8080/#/c/19697/5/bin/resolve_minidumps.py@1 PS5, Line 1: #!/usr/bin/env python3 This is already requiring python3, so we don't need to do anything here. -- To view, visit http://gerrit.cloudera.org:8080/19697 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idff388aff33817b0629347f5843ec34c78f0d0cb Gerrit-Change-Number: 19697 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 14 Apr 2023 00:17:57 +0000 Gerrit-HasComments: Yes
