Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/19744 )
Change subject: IMPALA-11970: Optimized rendering for the query timeline display ...................................................................... Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/19744/2/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/19744/2/www/query_timeline.tmpl@153 PS2, Line 153: fevents[en].tslist.push(fp.child_profiles[instance].event_sequences[0].events[en].timestamp); wrap long line. http://gerrit.cloudera.org:8080/#/c/19744/2/www/query_timeline.tmpl@176 PS2, Line 176: node_name = pp.profile_name.replace("_NODE", "").replace("_"," ").replace("KrpcDataStreamSender", "SENDER").replace("Hash Join Builder", "JOIN BUILD").replace("join node_","") wrap long line http://gerrit.cloudera.org:8080/#/c/19744/2/www/query_timeline.tmpl@285 PS2, Line 285: profile_available=false; Add spaces around = http://gerrit.cloudera.org:8080/#/c/19744/2/www/query_timeline.tmpl@312 PS2, Line 312: var screen_height = Math.min(timing_canvas.height + 10, window.innerHeight - timing_canvas.offsetTop - 30); Wrap long line http://gerrit.cloudera.org:8080/#/c/19744/2/www/query_timeline.tmpl@332 PS2, Line 332: }); Remove leading space http://gerrit.cloudera.org:8080/#/c/19744/2/www/query_timeline.tmpl@361 PS2, Line 361: timing_ctx.fillText("X", name_width + Math.min.apply(null,node.events[2].tslist) * px_per_ns, text_y, char_width); space after , on this and next lines. Wrap long lines. http://gerrit.cloudera.org:8080/#/c/19744/2/www/query_timeline.tmpl@467 PS2, Line 467: if (profile_available==false) { This new flag looks like it may cause the page to stop refreshing if the profile is retrieved but the query is not finished. http://gerrit.cloudera.org:8080/#/c/19744/2/www/query_timeline.tmpl@469 PS2, Line 469: }else{ spaces around else -- To view, visit http://gerrit.cloudera.org:8080/19744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec458602266863b6e313f52b26a2dc35cff0db0f Gerrit-Change-Number: 19744 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Comment-Date: Fri, 14 Apr 2023 16:30:32 +0000 Gerrit-HasComments: Yes
