Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/19744 )
Change subject: IMPALA-11970: Optimized rendering for the query timeline display ...................................................................... Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/19744/2/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/19744/2/www/query_timeline.tmpl@153 PS2, Line 153: } > wrap long line. Done http://gerrit.cloudera.org:8080/#/c/19744/2/www/query_timeline.tmpl@176 PS2, Line 176: .replace("KrpcDataStreamSender", "SENDER") > wrap long line Done http://gerrit.cloudera.org:8080/#/c/19744/2/www/query_timeline.tmpl@285 PS2, Line 285: }catch(e) { > Add spaces around = Done http://gerrit.cloudera.org:8080/#/c/19744/2/www/query_timeline.tmpl@312 PS2, Line 312: > Wrap long line Done http://gerrit.cloudera.org:8080/#/c/19744/2/www/query_timeline.tmpl@332 PS2, Line 332: header_ctx.fillStyle = "#000000"; > Remove leading space Done http://gerrit.cloudera.org:8080/#/c/19744/2/www/query_timeline.tmpl@361 PS2, Line 361: DrawBars(timing_ctx, rownum_l, height, node.events, name_width, px_per_ns); > space after , on this and next lines. Done http://gerrit.cloudera.org:8080/#/c/19744/2/www/query_timeline.tmpl@467 PS2, Line 467: } > This new flag looks like it may cause the page to stop refreshing if the pr Done http://gerrit.cloudera.org:8080/#/c/19744/2/www/query_timeline.tmpl@469 PS2, Line 469: > spaces around else Done -- To view, visit http://gerrit.cloudera.org:8080/19744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec458602266863b6e313f52b26a2dc35cff0db0f Gerrit-Change-Number: 19744 Gerrit-PatchSet: 4 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Fri, 14 Apr 2023 18:05:49 +0000 Gerrit-HasComments: Yes
