Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19746
Change subject: IMPALA-11974: Fix xrange, split in collect_diagnostics.py ...................................................................... IMPALA-11974: Fix xrange, split in collect_diagnostics.py Python3 deprecates xrange operator, this commit replaces it with the range operator similar to earlier replacements in IMPALA-11974. Adds decode() to command stdout before splitting. Popen returns bytes, which in Python 2 supports split while in Python 3 split requires a str object. In Python 2, decode converts bytes to unicode (which also support split); in Python 3, decode converts bytes to str. Testing: - Tested that Python3 parses this file successfully - Ran '$IMPALA_HOME/bin/diagnostics/collect_diagnostics.py --pid <pid> --minidumps 2 1 --minidumps_dir $IMPALA_HOME/logs/cluster/minidumps' and inspected the results. Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4 --- M bin/diagnostics/collect_diagnostics.py 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/19746/1 -- To view, visit http://gerrit.cloudera.org:8080/19746 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4 Gerrit-Change-Number: 19746 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]>
