Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19746 )
Change subject: IMPALA-11974: Fix xrange, split in collect_diagnostics.py ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19746/1/bin/diagnostics/collect_diagnostics.py File bin/diagnostics/collect_diagnostics.py: http://gerrit.cloudera.org:8080/#/c/19746/1/bin/diagnostics/collect_diagnostics.py@177 PS1, Line 177: return len(cmd.stdout.decode('utf-8').split("\n")) - 1 > Should Command's Popen call use universal_newlines? Yeah, it should. My first reading was that it was being used to write binary files, but looking back I think I misread that. -- To view, visit http://gerrit.cloudera.org:8080/19746 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52f075825d47613293b106a7c50d4499c19cd3f4 Gerrit-Change-Number: 19746 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Sat, 15 Apr 2023 04:28:32 +0000 Gerrit-HasComments: Yes
