Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19697 )
Change subject: IMPALA-9627: Update utility scripts for Python 3 (part 2) ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/19697/9/bin/diagnostics/collect_diagnostics.py File bin/diagnostics/collect_diagnostics.py: http://gerrit.cloudera.org:8080/#/c/19697/9/bin/diagnostics/collect_diagnostics.py@177 PS9, Line 177: # Decode ensures we have a string-like object to split; run returns bytes in Python3. > This fails with Python 3 because stdout is bytes, and split expects a strin Done http://gerrit.cloudera.org:8080/#/c/19697/9/infra/deploy/deploy.py File infra/deploy/deploy.py: http://gerrit.cloudera.org:8080/#/c/19697/9/infra/deploy/deploy.py@26 PS9, Line 26: > This file could be deleted completely. It's unused and probably doesn't wor Done -- To view, visit http://gerrit.cloudera.org:8080/19697 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idff388aff33817b0629347f5843ec34c78f0d0cb Gerrit-Change-Number: 19697 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 14 Apr 2023 17:57:00 +0000 Gerrit-HasComments: Yes
