Hello Joe McDonnell, Wenzhe Zhou, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19697
to look at the new patch set (#12).
Change subject: IMPALA-9627: Update utility scripts for Python 3 (part 2)
......................................................................
IMPALA-9627: Update utility scripts for Python 3 (part 2)
We're starting to see environments where the system Python ('python') is
Python 3. Updates utility and build scripts to work with Python 3, and
updates check-pylint-py3k.sh to check scripts that use system python.
Fixes other issues found during a full build and test run with Python
3.8 as the default for 'python'.
Fixes a impala-shell tip that was supposed to have been two tips (and
had no space after period when they were printed).
Adds decode() to command stdout before splitting. Popen returns bytes,
which in Python 2 supports split while in Python 3 split requires a str
object. In Python 2, decode converts bytes to unicode (which also
support split); in Python 3, decode converts bytes to str.
Removes out-of-date deploy.py.
Testing:
- Full build with /usr/bin/python pointed to python3
- run-all-tests passed with python pointed to python3
- Ran '$IMPALA_HOME/bin/diagnostics/collect_diagnostics.py --pid <pid>
--minidumps 2 1 --minidumps_dir $IMPALA_HOME/logs/cluster/minidumps
--stacks 2 1' with Python 2/3 and inspected the results.
Change-Id: Idff388aff33817b0629347f5843ec34c78f0d0cb
---
M be/src/codegen/gen_ir_descriptions.py
M bin/bootstrap_toolchain.py
M bin/check-pylint-py3k.sh
M bin/check-rat-report.py
M bin/collect_minidumps.py
M bin/compare_branches.py
M bin/create-test-configuration.sh
M bin/diagnostics/collect_diagnostics.py
M bin/gen-backend-test-script.py
M bin/gen_build_version.py
M bin/generate_xml_config.py
M bin/jenkins/critique-gerrit-review.py
M bin/jenkins/dockerized-impala-preserve-vars.py
M bin/jenkins/populate_m2_directory.py
M bin/push_to_asf.py
M bin/validate-unified-backend-test-filters.py
M common/function-registry/gen_builtins_catalog.py
M common/function-registry/gen_geospatial_udf_wrappers.py
M common/thrift/generate_error_codes.py
M common/thrift/generate_metrics.py
M docker/annotate.py
M docker/monitor.py
M docker/test-with-docker.py
M fe/src/test/resources/hive-site.xml.py
D infra/deploy/deploy.py
M infra/python/deps/find_py26.py
M infra/python/deps/pip_download.py
M lib/python/impala_py_lib/jenkins/generate_junitxml.py
M lib/python/impala_py_lib/jenkins/junitxml_prune_notrun.py
M shell/impala_shell.py
M testdata/bin/setup-ranger.sh
M testdata/cluster/admin
M testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py
M testdata/cluster/node_templates/common/etc/hadoop/conf/ozone-site.xml.py
M testdata/cluster/node_templates/common/etc/hadoop/conf/yarn-site.xml.py
M tests/comparison/data_generator_mapper.py
M tests/comparison/data_generator_reducer.py
37 files changed, 90 insertions(+), 531 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/19697/12
--
To view, visit http://gerrit.cloudera.org:8080/19697
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idff388aff33817b0629347f5843ec34c78f0d0cb
Gerrit-Change-Number: 19697
Gerrit-PatchSet: 12
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
