Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19750 )
Change subject: Update README about env setup ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/19750/1/README.md File README.md: http://gerrit.cloudera.org:8080/#/c/19750/1/README.md@9 PS1, Line 9: Other platforms might also be supported but are not well tested. To set up the build environment from scratch, refering to the specific docker files, e.g. docker/ubuntu1804.df. nit: refering -> refer. Referring expresses the verb as an adjective, where "To set up..., <do something>" expects a verb. http://gerrit.cloudera.org:8080/#/c/19750/1/README.md@63 PS1, Line 63: USE_CCACHE=0 DOWNLOAD_CCACHE=0 SYSTEM_GCC=1 CC=/usr/bin/gcc DEBUG=1 ./buildall.sh No need to set CXX? -- To view, visit http://gerrit.cloudera.org:8080/19750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11ecc5a1fac604b149b8789ba548dbba75558da4 Gerrit-Change-Number: 19750 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 17 Apr 2023 16:49:45 +0000 Gerrit-HasComments: Yes
